sparkle-devs/sparkle
Watch
3
0
Fork
You've already forked sparkle
 0
Code Issues 10 Pull requests Projects Releases 18 Packages Wiki Activity Actions

Fix mysterious JSON issues on Firefox #37

Merged
PPPDUD merged 1 commit from patch-firefox-json-bug into main 2026-05-14 17:57:30 -05:00
Conversation 10 Commits 1 Files changed 1 +2 -2
PPPDUD commented 2026-05-13 12:34:26 -05:00 (Migrated from github.com)
Copy link

On line 1592 the data variable should be a string and not an object. This should fix #36.

@e016 @Bubgamer07 Would you please test this patch? It works on my machine, Firefox 150.0.2 on Ubuntu 26.04.

On [line 1592](https://github.com/Mojavesoft-Group/sparkle/blob/18ebefb9abafd98f5db7b25f9e6ca90dbdc45c9f/index.js#L1592) the `data` variable should be a string and not an object. This should fix #36. @e016 @Bubgamer07 Would you please test this patch? It works on my machine, Firefox 150.0.2 on Ubuntu 26.04.
Bubgamer07 (Migrated from github.com) reviewed 2026-05-13 12:34:26 -05:00
e016 (Migrated from github.com) approved these changes 2026-05-13 13:06:20 -05:00
e016 (Migrated from github.com) left a comment
Copy link

Looks good!

Looks good!
Bubgamer07 commented 2026-05-13 13:17:05 -05:00 (Migrated from github.com)
Copy link

I'll test when i get home.

I'll test when i get home.
Bubgamer07 commented 2026-05-13 18:23:53 -05:00 (Migrated from github.com)
Copy link

im still getting this:
image

im still getting this: <img width="1920" height="956" alt="image" src="https://github.com/user-attachments/assets/8e39defa-73f8-46d6-b6cf-8b28a97ed3bb" />
PPPDUD commented 2026-05-13 18:25:12 -05:00 (Migrated from github.com)
Copy link

im still getting this: image

What addons do you have installed in Sparkle, and what programming language are you using?

> im still getting this: <img alt="image" width="1920" height="956" src="https://private-user-images.githubusercontent.com/148393011/592134744-8e39defa-73f8-46d6-b6cf-8b28a97ed3bb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg3MTQ5NjksIm5iZiI6MTc3ODcxNDY2OSwicGF0aCI6Ii8xNDgzOTMwMTEvNTkyMTM0NzQ0LThlMzlkZWZhLTczZjgtNDZkNi1iNmNmLThiMjhhOTdlZDNiYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNTEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDUxM1QyMzI0MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGQxZmQzMjA4NWNjODlkNWFlNDRlMTQ1OTI1NDE5YjA5ZWRjMDZjYjBkZjM5YWNhMjY5NmY3ZGM5Y2VmZjdmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.rYyL70FdhrJsDIy3NQU_Vq6-Pp9JVTRpv2WXKxGMiYQ"> What addons do you have installed in Sparkle, and what programming language are you using?
Bubgamer07 commented 2026-05-13 18:27:11 -05:00 (Migrated from github.com)
Copy link

im still getting this: image

What addons do you have installed in Sparkle, and what programming language are you using?

I'm using the addons i mentioned before, on normal Snap_!_

> > im still getting this: <img alt="image" width="1920" height="956" src="https://private-user-images.githubusercontent.com/148393011/592134744-8e39defa-73f8-46d6-b6cf-8b28a97ed3bb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg3MTQ5NjksIm5iZiI6MTc3ODcxNDY2OSwicGF0aCI6Ii8xNDgzOTMwMTEvNTkyMTM0NzQ0LThlMzlkZWZhLTczZjgtNDZkNi1iNmNmLThiMjhhOTdlZDNiYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNTEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDUxM1QyMzI0MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGQxZmQzMjA4NWNjODlkNWFlNDRlMTQ1OTI1NDE5YjA5ZWRjMDZjYjBkZjM5YWNhMjY5NmY3ZGM5Y2VmZjdmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.rYyL70FdhrJsDIy3NQU_Vq6-Pp9JVTRpv2WXKxGMiYQ"> > > What addons do you have installed in Sparkle, and what programming language are you using? I'm using the addons i mentioned before, on normal Snap_!_
PPPDUD commented 2026-05-13 18:29:04 -05:00 (Migrated from github.com)
Copy link

im still getting this: image

What addons do you have installed in Sparkle, and what programming language are you using?

I'm using the addons i mentioned before, on normal Snap_!_

Try uninstalling all of them and re-adding them one-by-one to find the problem.

> > > im still getting this: <img alt="image" width="1920" height="956" src="https://private-user-images.githubusercontent.com/148393011/592134744-8e39defa-73f8-46d6-b6cf-8b28a97ed3bb.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg3MTQ5NjksIm5iZiI6MTc3ODcxNDY2OSwicGF0aCI6Ii8xNDgzOTMwMTEvNTkyMTM0NzQ0LThlMzlkZWZhLTczZjgtNDZkNi1iNmNmLThiMjhhOTdlZDNiYi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNTEzJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDUxM1QyMzI0MjlaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00NGQxZmQzMjA4NWNjODlkNWFlNDRlMTQ1OTI1NDE5YjA5ZWRjMDZjYjBkZjM5YWNhMjY5NmY3ZGM5Y2VmZjdmJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.rYyL70FdhrJsDIy3NQU_Vq6-Pp9JVTRpv2WXKxGMiYQ"> > > > > > > What addons do you have installed in Sparkle, and what programming language are you using? > > I'm using the addons i mentioned before, on normal Snap_!_ Try uninstalling all of them and re-adding them one-by-one to find the problem.
e016 commented 2026-05-13 19:19:43 -05:00 (Migrated from github.com)
Copy link

Better Flat design doesn't seem to work, it has something to do with wrapFunction

Better Flat design doesn't seem to work, it has something to do with `wrapFunction`
e016 commented 2026-05-13 19:21:56 -05:00 (Migrated from github.com)
Copy link

It does work in the important-flag branch:

image

Maybe you need to merge that pull request...

It does work in the `important-flag` branch: <img width="377" height="282" alt="image" src="https://github.com/user-attachments/assets/481416a1-7eb7-49fe-9db9-e60c2e1d22cf" /> Maybe you need to merge that pull request...
PPPDUD commented 2026-05-14 05:24:20 -05:00 (Migrated from github.com)
Copy link

It does work in the important-flag branch:

image Maybe you need to merge that pull request...

I'm gonna be rather-occupied this week, so I might be pretty late to merge.

> It does work in the `important-flag` branch: > > <img alt="image" width="377" height="282" src="https://private-user-images.githubusercontent.com/244850916/592150845-481416a1-7eb7-49fe-9db9-e60c2e1d22cf.png?jwt=eyJ0eXAiOiJKV1QiLCJhbGciOiJIUzI1NiJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Nzg3NTQ1MTUsIm5iZiI6MTc3ODc1NDIxNSwicGF0aCI6Ii8yNDQ4NTA5MTYvNTkyMTUwODQ1LTQ4MTQxNmExLTdlYjctNDlmZS05ZGI5LWU2MGMyZTFkMjJjZi5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjYwNTE0JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI2MDUxNFQxMDIzMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1mN2M1ZmFiYWIzMzg3Y2UxZWFlOWY2ZTdiNjE2YWIxNmRhODVjNWFiOGQ4OGJiM2NhMWIzNzAxMWI4MzE0ZWNiJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZyZXNwb25zZS1jb250ZW50LXR5cGU9aW1hZ2UlMkZwbmcifQ.k8w4p6vvDRoXdf_0XdpG9VDl9849u_bUW3EVRbp12pQ"> > Maybe you need to merge that pull request... I'm gonna be rather-occupied this week, so I might be pretty late to merge.
Sign in to join this conversation.
Reviewers
No reviewers
Bubgamer07
e016
Labels
Clear labels   
bug
Something isn't working

  
discussion

   
documentation
Improvements or additions to documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature or request

  
good first issue
Good for newcomers

  
help wanted
Extra attention is needed

  
invalid
This doesn't seem right

  
Jameson
Related to Jameson

  
joke
Joke issue.

  
options window
Bugs in the addon options window.

  
question
Further information is requested

  
Split!
Related to Split!

  
wontfix
This will not be worked on

No labels
bug
discussion
documentation
duplicate
enhancement
good first issue
help wanted
invalid
Jameson
joke
options window
question
Split!
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
sparkle-devs/sparkle!37
No description provided.