Addons!

d016 commented

2026-08-15 18:03:29 -05:00

Collaborator

Still need a better mod manager and user mod loader, but this PR already includes the loadMod funcion.

Everything automatically gets saved; no ""autoloading""!

Still need a better mod manager and user mod loader, but this PR already includes the `loadMod` funcion. Everything automatically gets saved; no ""autoloading""!

d016 added 2 commits

2026-08-15 18:03:29 -05:00

start addon loading 37cdd82d78

finish core addon loading 4dc6b101e2

playforge-coding commented

2026-08-15 18:07:34 -05:00

Contributor

Why are there em dashes 🤨

d016 commented

2026-08-15 18:15:46 -05:00

Author

Collaborator

@playforge-coding wrote in #9 (comment):

Why are there em dashes 🤨

where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it?

@playforge-coding wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2350: > Why are there em dashes :raised_eyebrow: where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it?

👍 1

d016 commented

2026-08-15 18:17:39 -05:00

Author

Collaborator

Also, no, I have not used any Generative AI in this PR.

(The screenshot isn't proof. It's just a detail showcasing 0 em dashes)

Also, no, I have not used any Generative AI in this PR. ![image](/attachments/6e5df49f-2289-4225-af5d-a32d2eba7bf4) (The screenshot isn't proof. It's just a detail showcasing 0 em dashes)

image.png

4.8 KiB

👍 1

playforge-coding commented

2026-08-15 18:20:57 -05:00

Contributor

@d016 wrote in #9 (comment):

@playforge-coding wrote in #9 (comment):

Why are there em dashes 🤨

where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it?

Ok, it seems like it is a hyphen, but it is used as an em dash. So probably human.

@d016 wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2351: > @playforge-coding wrote in #9 (comment): > > > Why are there em dashes :raised_eyebrow: > > where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it? Ok, it seems like it is a hyphen, but it is used as an em dash. So probably human.

d016 commented

2026-08-15 18:25:49 -05:00

Author

Collaborator

I've finished the main mod loading functions, although there's no mod manager yet.

I think this is ready for merging. @codingisfun2831t what do you think about this?

I've finished the main mod loading functions, although there's no mod manager yet. ![image](/attachments/9188bee2-052c-4c13-b29e-57eba4a8d9fa) I think this is ready for merging. @codingisfun2831t what do you think about this?

image.png

6.2 KiB

PPPDUD commented

2026-08-15 19:19:05 -05:00

First-time contributor

@d016 wrote in #9 (comment):

@playforge-coding wrote in #9 (comment):

Why are there em dashes 🤨

where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it?

@d016, aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution.

(I'm not a lawyer and this is not legal advice.)

@d016 wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2351: > @playforge-coding wrote in #9 (comment): > > > Why are there em dashes :raised_eyebrow: > > where? I will admit though, I have copied some parts of Sparkle's example.js. Is that it? @d016, aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution. (I'm not a lawyer and this is not legal advice.)

👍 1

d016 commented

2026-08-15 19:33:23 -05:00

Author

Collaborator

@PPPDUD wrote in #9 (comment):

aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution.

should we? I did contribute to sparkle, but then again...

@PPPDUD wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2355: > aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution. should we? I _did_ contribute to sparkle, but then again...

PPPDUD commented

2026-08-15 19:36:32 -05:00

First-time contributor

@d016 wrote in #9 (comment):

@PPPDUD wrote in #9 (comment):

aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution.

should we? I did contribute to sparkle, but then again...

It's a file that's been worked on by multiple people, me included, so it's probably a good idea just to be safe.

@d016 wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2356: > @PPPDUD wrote in #9 (comment): > > > aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution. > > should we? I _did_ contribute to sparkle, but then again... It's a file that's been worked on by multiple people, me included, so it's probably a good idea just to be safe.

playforge-coding commented

2026-08-15 19:44:06 -05:00

Contributor

@d016 wrote in #9 (comment):

@PPPDUD wrote in #9 (comment):

aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution.

should we? I did contribute to sparkle, but then again...

@d016 wrote in https://git.hermits.cc/codingisfun2831t/Crackle/pulls/9#issuecomment-2356: > @PPPDUD wrote in #9 (comment): > > > aren't you supposed to leave a license notice whenever you take considerable portions of MIT-licensed code? Normally I don't care because it's an example, but if it's going to be used to compete with Sparkle, I think that we warrant at least a bit of attribution. > > should we? I _did_ contribute to sparkle, but then again... <video src="/attachments/1ff0a1b1-7267-40be-92f5-7b2c700e3ee2" title="criminal" controls></video>

criminal.mp4

694 KiB

😆 2

d016 added 1 commit

2026-08-15 19:54:22 -05:00

add basic "Import Addon from Code" feature. 608b0ec126

This pull request can be merged automatically.

This branch is out-of-date with the base branch

You are not authorized to merge this pull request.

View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.

git fetch -u origin addons:addons

git switch addons

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main

git merge --no-ff addons

git switch addons

git rebase main

git switch main

git merge --ff-only addons

git switch addons

git rebase main

git switch main

git merge --no-ff addons

git switch main

git merge --squash addons

git switch main

git merge --ff-only addons

git switch main

git merge addons

git push origin main

Rows
Columns

Addons! #9

Checkout

Merge