WIP: add reporter block shapes mod - only color for now #20
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
jameson addon
question
waiting for next release
wontfix
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
sparkle-devs/SparkleAddons!20
Loading…
Reference in a new issue
No description provided.
Delete branch "codingisfun2831t-mods"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I wanted to add object but I couldn't change the layout code.
I'm going to do a clipboard thing next but first I want to fix up wrapFunction with the one I was using in the sparkle class.
Will try to review soon, but probably won't be available today; thanks for the submission!
I think for object-shaped reporters, you can apply a function wrap for fixLayout, moving everything more to the right to make space for the block shape. I'm not sure if this would work well for C-Slots, though.
@codingisfun2831t What in the world is this meant to do? Do you have a screenshot demonstrating this addon at work?
It just makes the shape for any reporter returning a color (via the new reports type feature in Snap! 12) and then changes that to a rectangle to mimic the color input. It also makes "pen color" have that shaped also (via the same technique as
isStop)I think it's supposed to add the block shapes that Snavanced adds (square, "object" shaped, etc...)
I've noticed some other issues. First, it doesn't use the
flatEdgeproperty that gives flat design blocks its borders:Also, it doesn't work in Split! (which isn't surprising)
Square blocks also make it seem like you can fit them into static, read-only slots:
This issue will be amplified in Split, as square dropdowns are always static, and round dropdowns can have blocks on them:
Ill fix the flatEdge and Split! support tomorrow, but I dont think the "static, readonly" slots thing really fits. If you think that looks like that, dont use the mod!
Thanks. I also feel like you could also/instead make string blocks square, as text inputs are also square. Possibly as an option?
Thankfully, I see everything you and others say about my mod on the forums, but these are so interesting that I'm surprised, thanks for giving some feedback to Snavanced!
I think the user could choose what type the square block should be used for, so the user can choose between list, color, text, etc...
I personally prefer it when the visuals can easily show what can and can't fit.
(Image from EV3 Lab. Data wires have bumps that depend on the data type, that fit or don't fit depending on the shape, it's like a child's shape insertion toy)
I got the object blocks to work!!
Nice! Would you be able to make a PR for it to my codingisfun2831t-mods branch (or just commit it to that outright)
@d016 Your version of the mod looks good, but why is it a seperate file? Would I be able to change it to reporter-block-shapes.js?
whoops... you can change it!
@codingisfun2831t @e016 Any updates on this?
View command line instructions
Checkout
From your project repository, check out a new branch and test the changes.Merge
Merge the changes and update on Forgejo.Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.